[SSF-129] add tracking link and shipping cost to order#95
Open
[SSF-129] add tracking link and shipping cost to order#95
Conversation
dburkhart07
requested changes
Feb 4, 2026
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
Few small things. Can you update the frontend type for Order too while you're at it?
dburkhart07
approved these changes
Feb 4, 2026
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
Approving for now with a question for @Yurika-Kan and @sam-schu.
Perhaps, in the service function, do we want to make sure that we are not putting a tracking link and shipping cost on a pending order? I imagine the flow is that we would never want to call this endpoint on a pending order (if its going from pending to shipped, id imagine we would first call updateStatus and then this one, to which we could still implement this).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes SSF-129
📝 Description
✔️ Verification
Verified endpoint on Postman and data changes in pgAdmin
🏕️ (Optional) Future Work / Notes
Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!